Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make billing info field checkbox #4651

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

snitin315
Copy link
Member

Fixes #4650

Short description of what this resolves:

make required billing info field a checkbox instead of the radio.

Changes proposed in this pull request:

Screenshot at 2020-07-28 15-03-38

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Jul 28, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/j5jhn184i
✅ Preview: https://open-event-frontend-git-fork-snitin315-fix-billing-info.eventyay.vercel.app

Comment on lines -564 to +571
<div class="ui radio checkbox">
<div class="ui checkbox">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main change is here, rest is formatting.

@auto-label auto-label bot added the fix label Jul 28, 2020
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #4651 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4651   +/-   ##
============================================
  Coverage        23.08%   23.08%           
============================================
  Files              475      475           
  Lines             4952     4952           
  Branches             8        8           
============================================
  Hits              1143     1143           
  Misses            3808     3808           
  Partials             1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62fd18d...38950f3. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 1c8ee53 into fossasia:development Jul 28, 2020
@snitin315 snitin315 deleted the fix/billing-info branch July 28, 2020 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wizard Step 1 Basic Details: "Require Billing Info" change button to tickbox
2 participants